use uint16 for treeArity in PollFactory.deploy #313
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In maci/contracts/contracts/Poll.sol,
since the type of
treeArity
isuint8
,in
treeArity ** _treeDepths.messageTreeDepth
seems to overflow when_treeDepths.messageTreeDepth
is greater than3
, i.e.5^3 = 125
but5^4 = 625
which is greater than256
, and that makes the require statement fail.The type of
treeArity
should be a type that can store larger values without overflow.