-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix proof generation for subsequential polls #317
Fix proof generation for subsequential polls #317
Conversation
|
||
node build/index.js timeTravel -s 140 && \ | ||
node build/index.js mergeMessages -x 0xf204a4Ef082f5c04bB89F7D5E6568B796096735a -o 1 && \ | ||
node build/index.js mergeSignups -x 0xf204a4Ef082f5c04bB89F7D5E6568B796096735a -o 1 && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without changing how the sbCommitments are updated, this command is still necessary even though the StateAq subtrees are merged.
Hi! Does this include #311 or should that be merged separately? |
|
Suggestions to reduce the size of Poll.sol:
|
We should reduce the size of Poll.sol before merging this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and the test script works on my end too. We just need to reduce the size of Poll.sol - see the previous comment on how we can do this.
Edit: let's do the size reduction in a different PR.
Instead of allowing concurrent polls where users must signup for each poll, this PR aims to allow on chain proof verification for a multiple poll instances with the same set of users.
Testing run
cli/testMultiplePoll.sh