Save each proof in its own file, rather than one big proofs.json #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corydickson
reviewed
Dec 9, 2021
rm -rf proofs and tally file in suites Co-authored-by: corydickson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there are many messages, there will be many batches of proofs to store. Previously, MACI saved them in a single JSON file, but clrfund round 8 taught us that if this file gets too large, we won't be able to easily parse it due to the string length limit in Nodejs.
As such, this PR makes genProofs save each proof in its own file in a user-specified proofs directory.
Addresses #316