Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate function for totalSupply #343

Merged

Conversation

corydickson
Copy link
Contributor

No description provided.

@corydickson
Copy link
Contributor Author

@kcharbo3

@kcharbo3
Copy link

Can probably remove the curTokenId field as well and replace it in the giveToken function with a call to totalSupply()?

// remove: uint256 curTokenId = 1;

// Gives an ERC721 token to an address
function giveToken(address to) public onlyOwner {
    _mint(to, totalSupply());
}

This would start the first token to have id of 0. This is what I usually see, but if you want the first token id to be 1, then you could easily adjust that.

@corydickson corydickson merged commit 46ca4bd into privacy-scaling-explorations:v1 Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants