Subsidy calculation #406
Merged
Subsidy calculation #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add verify subsidy result; remove outdated circom files; add test.sh testMultipleBatches.sh; update zkey.config.yml;
baumstern
reviewed
Apr 16, 2022
There was a problem hiding this comment.
Figured out unwrapping BigInt to bigint fixes the current build failure of maci-core:
error TS2345: Argument of type 'BigInt' is not assignable to parameter of type 'string | number | bigint | boolean'.
This comment was marked as resolved.
This comment was marked as resolved.
baumstern
reviewed
Apr 16, 2022
Agree, this feature had better be optional. People who run QV don't need to do subsidy calculation. |
Thanks! updated these changes |
Co-authored-by: Daehyun Paik <[email protected]>
Yeah, I have made the subsidy calculation optional. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.