Check if .dat file exists when running genProofs command
#434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The build failing looks unrelated, but looks good! |
corydickson
reviewed
May 21, 2022
baumstern
force-pushed
the
check-dat
branch
2 times, most recently
from
705da95 to
9bb2012
Compare
|
🎉 2.0.4 circom |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add checks for
.datfile (one of the artifact of compiled circuit and it is required to execute witness generation) and print error if it doesn't exist.Currently, when user execute
genProofscommand without.datfile, they will got ambiguous error doesn't address explicitly they missed.datfile.