rewrite float division circuit #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
chaosma
commented
Sep 21, 2022
•
chaosma
commented
- use a similar algorithm which has more relax condition for inputs
- check divisor not equal zero
- check inputs not overflow for float division and representation
- check multiplication a*b not overflow
- to avoid subsidy formula overflow, add comments on voice credit contracts
use a similar but require less constraint for IntegerDivision
add a*b overflow check in float.circom
… constants (1) M in subsidy calculation (2) hard cap of voice credit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.