New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contract refactor #599

Merged

daodesigner merged 16 commits into privacy-scaling-explorations:dev from chaosma:contract-refactor

Apr 3, 2023

Contributor

chaosma commented Jan 31, 2023 •

edited

Loading

separation of MessageProcessor, Tally and Subsidy contracts out according to the circuits
various minor optimizations on contracts
fixed broken unit tests

chaosma force-pushed the contract-refactor branch 2 times, most recently from 66a6f6d to 6ed846c Compare

February 9, 2023 04:04

chaosma closed this

baumstern reopened this

baumstern changed the base branch from v1 to dev

February 9, 2023 18:14

chaosma force-pushed the contract-refactor branch from 6ed846c to c684cd1 Compare

February 16, 2023 11:17

ctrlc03 reviewed

View reviewed changes

contracts/contracts/Tally.sol Show resolved Hide resolved

ctrlc03 reviewed

View reviewed changes

contracts/contracts/Tally.sol Outdated Show resolved Hide resolved

ctrlc03 reviewed

View reviewed changes

contracts/contracts/Tally.sol Outdated Show resolved Hide resolved

ctrlc03 reviewed

View reviewed changes

contracts/contracts/Tally.sol Outdated Show resolved Hide resolved

ctrlc03 reviewed

View reviewed changes

contracts/contracts/Tally.sol Show resolved Hide resolved

ctrlc03 reviewed

View reviewed changes

contracts/contracts/Tally.sol Show resolved Hide resolved

ctrlc03 reviewed

View reviewed changes

contracts/contracts/Tally.sol Outdated Show resolved Hide resolved

ctrlc03 reviewed

View reviewed changes

contracts/contracts/Tally.sol Outdated Show resolved Hide resolved

ctrlc03 reviewed

View reviewed changes

contracts/contracts/Tally.sol Show resolved Hide resolved

ctrlc03 reviewed

View reviewed changes

contracts/contracts/Utility.sol Outdated Show resolved Hide resolved

ctrlc03 reviewed

View reviewed changes

contracts/contracts/Tally.sol Show resolved Hide resolved

ctrlc03 reviewed

View reviewed changes

contracts/contracts/Subsidy.sol Outdated Show resolved Hide resolved

ctrlc03 reviewed

View reviewed changes

contracts/contracts/Subsidy.sol Outdated Show resolved Hide resolved

ctrlc03 reviewed

View reviewed changes

contracts/contracts/Subsidy.sol Show resolved Hide resolved

ctrlc03 reviewed

View reviewed changes

contracts/contracts/Subsidy.sol Outdated Show resolved Hide resolved

ctrlc03 reviewed

View reviewed changes

contracts/contracts/Subsidy.sol Show resolved Hide resolved

ctrlc03 reviewed

View reviewed changes

contracts/contracts/Subsidy.sol Outdated Show resolved Hide resolved

ctrlc03 reviewed

View reviewed changes

contracts/contracts/Subsidy.sol Outdated Show resolved Hide resolved

ctrlc03 reviewed

View reviewed changes

contracts/contracts/Subsidy.sol Show resolved Hide resolved

ctrlc03 reviewed

View reviewed changes

contracts/contracts/Subsidy.sol Outdated Show resolved Hide resolved

ctrlc03 reviewed

View reviewed changes

contracts/contracts/Subsidy.sol Show resolved Hide resolved

ctrlc03 reviewed

View reviewed changes

contracts/contracts/MessageProcessor.sol Outdated Show resolved Hide resolved

ctrlc03 reviewed

View reviewed changes

contracts/contracts/MessageProcessor.sol Outdated Show resolved Hide resolved

ctrlc03 reviewed

View reviewed changes

contracts/contracts/MessageProcessor.sol Outdated Show resolved Hide resolved

ctrlc03 reviewed

View reviewed changes

contracts/contracts/MessageProcessor.sol Outdated Show resolved Hide resolved

ctrlc03 linked an issue

that may be closed by this pull request

Audit Smart Contract Changes #617

Closed

6 tasks

daodesigner suggested changes

View reviewed changes

Contributor

daodesigner left a comment

daodesigner mentioned this pull request

Smart Contract Refactor: Process Messages Test coverage #630

Closed

chaosma force-pushed the contract-refactor branch from 91d5983 to ae93b61 Compare

March 8, 2023 14:00

Contributor Author

chaosma commented Mar 9, 2023

thanks for the comments. many good optimizations

chaosma added 13 commits

March 9, 2023 23:51


          remove obsolete codes in Poll.sol

cc9c23c


          refactor Process and Utility out (WIP)

16a5deb


          add MessageProcessor deployer; fix cli for message processing

c7b8a91


          refactoring Tally; add cli related functions for tally

f6f8d5e


          minor fix on tally.sol

a34b192


          add subsidy.sol

c32e45f


          fixed subsidy related cli for Subsidy.sol; fix Subsidy.sol issue;

36446fc

add verify.ts back (WIP)


          refactor(refactor verify.ts): refactor verify cli command for Tally a…

dedfda6

…nd Subsidy contracts


          fix(address pr reviews): address PR reviews issues for Tally.sol

10f2c7f


          fix(fix subsidy.sol issues): address PR on Subsidy.sol

bb68116


          continue address Subsidy.sol PR issues;

b9bcd46


          fix compiler warning messages on contracts

803c3e5


          fix(address messageprocessor issues): address and fixed PR reviews on…

6505fb2

… MessageProcessor.sol

chaosma force-pushed the contract-refactor branch from 42db686 to 6505fb2 Compare

March 9, 2023 16:20

chaosma added 2 commits

March 10, 2023 00:49


          fix HasherBenchmark unit test; remove uncheck for potential overflow

e87ea1a


          fix(contract unit test): fixed unit test suites error caused by contr…

0dca2c0

…acts refactor

chaosma force-pushed the contract-refactor branch from e37b2f9 to 0dca2c0 Compare

March 23, 2023 04:00

chaosma changed the title ~~Contract refactor (WIP)~~ Contract refactor


          fix(fix integrationtests): fix integrationTests caused by refactoring

09ae37f

chaosma force-pushed the contract-refactor branch from 71e4365 to 09ae37f Compare

March 23, 2023 17:14

Member

baumstern commented Mar 23, 2023

+1 Fixing broken test

daodesigner approved these changes

View reviewed changes

daodesigner merged commit b98bd82 into privacy-scaling-explorations:dev

chaosma deleted the contract-refactor branch

April 6, 2023 10:11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet