Add verifyTallyResult, verifyPerVOSpentVoiceCredits, verifySpentVoiceCredits #835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for maci-typedoc failed.
|
ctrlc03
requested changes
Dec 8, 2023
yuetloo
force-pushed
the
fix/verify-tally-on-chain
branch
from
cce6a6b to
8165968
Compare
ctrlc03
approved these changes
Dec 8, 2023
This was referenced Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the functions to the new Tally contract as I think they were accidentally removed from code refactoring as they were available in v0.10 and v1.1 (incorrect implementation, see PR #742 )
Clrfund uses these functions to verify the tally results in the tally.json file on-chain as part of the round finalization and when recipients invoke the
claimFundsfunction.Note: I moved the standalone test
deployPollWithRandomSigner.test.tsin thesuites.test.tsas it was failing withnonceerror caused by running the tests in parallel.Run the integration test suites to test the new functions: