Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(commitments): store tally commitments to be used for verification #877

Merged
merged 2 commits into from
Dec 7, 2023
Merged

feat(commitments): store tally commitments to be used for verification #877

merged 2 commits into from
Dec 7, 2023

Conversation

ctrlc03
Copy link
Collaborator

@ctrlc03 ctrlc03 commented Dec 6, 2023 •
edited
Loading

  • Save tally commitments to the tally.json file
  • Implement an interface for the tally data
  • Return the object too for better access in tests
  • Small refactoring to accept the object as parameter in the verify function
  • Amend tests (e2e and integration)

fix #760

@netlify Netlify
Copy link

netlify bot commented Dec 6, 2023 •
edited
Loading

❌ Deploy Preview for maci-typedoc failed.

Name Link
🔨 Latest commit 56f7afa
🔍 Latest deploy log https://app.netlify.com/sites/maci-typedoc/deploys/657235f80bf7d600084ea24c

baumstern
baumstern suggested changes Dec 7, 2023
View reviewed changes
Copy link
Member

@baumstern baumstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. Just left some suggestions and improvements.

cli/ts/commands/verify.ts Outdated Show resolved Hide resolved
cli/ts/commands/genProofs.ts Outdated Show resolved Hide resolved
cli/ts/commands/genProofs.ts Show resolved Hide resolved
cli/tests/e2e.test.ts Show resolved Hide resolved
cli/tests/e2e.test.ts Show resolved Hide resolved
cli/tests/e2e.test.ts Show resolved Hide resolved
cli/ts/commands/verify.ts Outdated Show resolved Hide resolved
cli/ts/utils/interfaces.ts Outdated Show resolved Hide resolved
@ctrlc03 ctrlc03 requested a review from baumstern December 7, 2023 18:58
@ctrlc03 ctrlc03 self-assigned this Dec 7, 2023
@ctrlc03
Copy link
Collaborator Author

ctrlc03 commented Dec 7, 2023

Looks good overall. Just left some suggestions and improvements.

Changes made, PTAL when you get a chance

baumstern
baumstern previously approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@baumstern baumstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Can you just fix the prettier error?

0xmad
0xmad previously approved these changes Dec 7, 2023
View reviewed changes
Copy link
Collaborator

@0xmad 0xmad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ctrlc03 looks good, thanks!

@ctrlc03 ctrlc03 dismissed stale reviews from 0xmad and baumstern via 40cd946 December 7, 2023 21:15
@ctrlc03
feat(commitments) - save tally commitments to the tally file, impleme…
2ad7155 
…nt an interface and return the object too for better access in tests, small refactoring to accept the object as parameter in the verify function
@ctrlc03
feat(commitments) - ensure we are not saving the provider URL, allow …
56f7afa 
…one test to run with the local tally.json file to ensure all paths work correctly, amend interface
@ctrlc03 ctrlc03 requested review from baumstern and 0xmad December 7, 2023 21:16
@ctrlc03 ctrlc03 merged commit 32351a4 into dev Dec 7, 2023
11 checks passed
@ctrlc03 ctrlc03 deleted the feat/commitments branch December 7, 2023 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xmad 0xmad 0xmad approved these changes

@samajammin samajammin Awaiting requested review from samajammin

@baumstern baumstern Awaiting requested review from baumstern

Assignees

@ctrlc03 ctrlc03

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@ctrlc03 @baumstern @0xmad