tests(key-change): add tests and docs related to MACI's key change #885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for maci-typedoc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Super cool. It's much needed. |
ctrlc03
force-pushed
the
tests/key-change
branch
3 times, most recently
from
dea1c25 to
ccef119
Compare
ctrlc03
force-pushed
the
tests/key-change
branch
from
ccef119 to
b75a462
Compare
baumstern
suggested changes
Dec 11, 2023
| VOTE_OPTION_TREE_DEPTH, | ||
| coordinatorPubKey, | ||
| ); | ||
| stateIndex = parseInt(await signup(keypair1.pubKey.serialize())); |
There was a problem hiding this comment.
Suggested change
| stateIndex = parseInt(await signup(keypair1.pubKey.serialize())); | |
| stateIndex = await signup(keypair1.pubKey.serialize()); |
nit: it's better to return number type from signup()
There was a problem hiding this comment.
@baumstern Can you please dismiss your change request as this is something not related to this PR? will amend in another PR
kittybest
reviewed
Dec 11, 2023
cli/tests/keyChange.test.ts
Outdated
| const pollId = 0; | ||
| let stateIndex = 0; | ||
| const expectedTally = initialVoteAmount - 1; | ||
| const expectedPerVOteOptionTally = (initialVoteAmount - 1) ** 2; |
There was a problem hiding this comment.
I wanna ask why is expectedPerVOteOptionTally except for expectedPerVoteOptionTally?
There was a problem hiding this comment.
Could you please rephrase that? I'm afraid I didn't get it
There was a problem hiding this comment.
oh just wanna ask why the character 'o' is capitalized XD
ctrlc03
force-pushed
the
tests/key-change
branch
from
b75a462 to
852510c
Compare
baumstern
approved these changes
Dec 12, 2023
ctrlc03
force-pushed
the
tests/key-change
branch
from
852510c to
ce394e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, it is not clear how the key change mechanism works (or doesn't), hence this PR aims to provide some clarification on this front, by adding docs and test cases.
This is in reference to this: #717