Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(repo): remove redundant code from certain packages #920

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

ctrlc03
Copy link
Collaborator

@ctrlc03 ctrlc03 commented Dec 15, 2023

Description

  • do not save witness and inputs to file in the circuit tests
  • use asHex consistently.

Confirmation

Copy link

netlify bot commented Dec 15, 2023

Deploy Preview for maci-typedoc ready!

Name Link
🔨 Latest commit d55497a
🔍 Latest deploy log https://app.netlify.com/sites/maci-typedoc/deploys/658014c5f84f7d0008f51199
😎 Deploy Preview https://deploy-preview-920--maci-typedoc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ctrlc03 ctrlc03 force-pushed the fix/small-bug-fixes branch from fdc3251 to 58b75f9 Compare December 15, 2023 14:31
@ctrlc03 ctrlc03 self-assigned this Dec 15, 2023
Copy link
Member

@baumstern baumstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

do not save witness and inputs to file in the circuit tests, use asHex consistently.
@ctrlc03 ctrlc03 force-pushed the fix/small-bug-fixes branch from 58b75f9 to d55497a Compare December 18, 2023 09:45
@ctrlc03 ctrlc03 merged commit 9aebd20 into dev Dec 18, 2023
12 checks passed
@ctrlc03 ctrlc03 deleted the fix/small-bug-fixes branch December 18, 2023 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants