Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(proofs): add preferred witness type in circuit's genProof function #925

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

ctrlc03
Copy link
Collaborator

@ctrlc03 ctrlc03 commented Dec 15, 2023

Description

Remove isArm check in circuits and instead accept a parameter to decide which witness type to use. Made appropriate changes in tests and cli.

This allows to use wasm witness in an intel chip as well should this be preferred.

Confirmation

@ctrlc03 ctrlc03 self-assigned this Dec 15, 2023
Copy link

netlify bot commented Dec 15, 2023

Deploy Preview for maci-typedoc ready!

Name Link
🔨 Latest commit 2b95044
🔍 Latest deploy log https://app.netlify.com/sites/maci-typedoc/deploys/6596db30bd09e700082307fb
😎 Deploy Preview https://deploy-preview-925--maci-typedoc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ctrlc03 ctrlc03 changed the title feat(proofs): make preferred witness type in circuit's genProof function feat(proofs): add preferred witness type in circuit's genProof function Dec 16, 2023
@ctrlc03 ctrlc03 force-pushed the fix/wasm-c branch 2 times, most recently from 9af2e8a to 73a2006 Compare December 29, 2023 11:56
@ctrlc03 ctrlc03 force-pushed the fix/wasm-c branch 2 times, most recently from afd3d65 to 148cef5 Compare December 30, 2023 20:26
@kittybest
Copy link
Collaborator

The code lgtm.
I believe the objective of this pull request is to enable wasm support on Intel chips, if users prefer. However, considering that most users might simply want the code to be executable, I propose retaining the isArm() check in genProof. Additionally, we can introduce useWasm as a parameter for those interested in experimenting with options beyond the default configuration.
If I misunderstood it, please tell me~~

@ctrlc03
Copy link
Collaborator Author

ctrlc03 commented Jan 2, 2024

The code lgtm. I believe the objective of this pull request is to enable wasm support on Intel chips, if users prefer. However, considering that most users might simply want the code to be executable, I propose retaining the isArm() check in genProof. Additionally, we can introduce useWasm as a parameter for those interested in experimenting with options beyond the default configuration. If I misunderstood it, please tell me~~

mm I like this thinking, it would definitely make it easier for users to use. We could make the flag useWasm optional, and then add some more checks, I'll do that now

@ctrlc03 ctrlc03 force-pushed the fix/wasm-c branch 4 times, most recently from 391a833 to 8618acf Compare January 3, 2024 15:22
Remove isArm check in circuits and instead accept a parameter to decide which witness type to use.
Made appropriate changes in tests and cli
@ctrlc03 ctrlc03 merged commit 59ef195 into dev Jan 4, 2024
12 checks passed
@ctrlc03 ctrlc03 deleted the fix/wasm-c branch January 4, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants