Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(coverage): setup coverage for TS packages #932

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Conversation

ctrlc03
Copy link
Collaborator

@ctrlc03 ctrlc03 commented Dec 18, 2023

Description

setup code coverage for TS packages using istanbul (nyc)

Related issue(s)

fix #931

Confirmation

@ctrlc03 ctrlc03 self-assigned this Dec 18, 2023
Copy link

netlify bot commented Dec 18, 2023

Deploy Preview for maci-typedoc ready!

Name Link
🔨 Latest commit f4e6964
🔍 Latest deploy log https://app.netlify.com/sites/maci-typedoc/deploys/6593edc02218e5000844be03
😎 Deploy Preview https://deploy-preview-932--maci-typedoc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ctrlc03 ctrlc03 force-pushed the test/coverage branch 2 times, most recently from f4e2735 to b82a54b Compare December 29, 2023 11:56
@ctrlc03 ctrlc03 force-pushed the test/coverage branch 2 times, most recently from e3d1c9a to 501689b Compare December 30, 2023 20:26
@kittybest
Copy link
Collaborator

Will we also add nyc to circuits package? I think we're also using mocha to run tests in that package.
Also will we use another tool to test the code coverage for smart contracts? I think there are some packages such as solidity-coverage.

@ctrlc03
Copy link
Collaborator Author

ctrlc03 commented Jan 2, 2024

Will we also add nyc to circuits package? I think we're also using mocha to run tests in that package.

Also will we use another tool to test the code coverage for smart contracts? I think there are some packages such as solidity-coverage.

For the circuits package, it depends if we want to add unit tests for the ts code that is there (might be worth doing). If it's just for the circuits, then I'm afraid it wont really work with circom code, and I don't really know of any coverage tool for circom code unfortunately, we should do some research there.

Yes for contract there's that one, tho I tried to set it up and was having some issues with contract size due to the tool bloating contracts for collecting coverage, so I thought it would be best if we were to tackle that in a separate PR

setup code coverage for TS packages using istanbul (nyc)
@ctrlc03 ctrlc03 merged commit e951d8e into dev Jan 2, 2024
12 checks passed
@ctrlc03 ctrlc03 deleted the test/coverage branch January 2, 2024 16:47
@kittybest kittybest mentioned this pull request Jan 18, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Setup code coverage (TS)
2 participants