test(domainobjs): implement unit tests for the domainobjs package #934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for maci-typedoc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ctrlc03
force-pushed
the
test/domainobjs
branch
2 times, most recently
from
d245d9f to
635200a
Compare
ctrlc03
force-pushed
the
test/domainobjs
branch
5 times, most recently
from
8e14bc1 to
f71a56a
Compare
kittybest
reviewed
Jan 2, 2024
ctrlc03
force-pushed
the
test/domainobjs
branch
from
f71a56a to
fc19ab8
Compare
kittybest
reviewed
Jan 2, 2024
kittybest
reviewed
Jan 2, 2024
kittybest
reviewed
Jan 2, 2024
ctrlc03
force-pushed
the
test/domainobjs
branch
2 times, most recently
from
4b8608e to
6005c16
Compare
ctrlc03
force-pushed
the
test/domainobjs
branch
3 times, most recently
from
5fa9643 to
a5e490c
Compare
kittybest
reviewed
Jan 4, 2024
| expect(sk1.rawPrivKey.toString()).to.eq(BigInt(`${c.rawPrivKey}`).toString()); | ||
| }); | ||
| it("should always return a key with the same length", () => { | ||
| for (let i = 100; i < 100; i += 1) { |
There was a problem hiding this comment.
weird here, this for loop will never run.
There was a problem hiding this comment.
oh my, I put i = 100; i < 100 🤦
ctrlc03
force-pushed
the
test/domainobjs
branch
from
a5e490c to
a78521a
Compare
ctrlc03
force-pushed
the
test/domainobjs
branch
from
a78521a to
c19d1d3
Compare
kittybest
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement more unit tests in the domainobjs package to ensure the code is thoroughly tested.
Related issue(s)
fix #929
Confirmation