-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(crypto): improve package structure #935
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for maci-typedoc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ctrlc03
force-pushed
the
refactor/crypto-cleanup
branch
2 times, most recently
from
December 29, 2023 11:58
de77192
to
d9d9b58
Compare
ctrlc03
force-pushed
the
refactor/crypto-cleanup
branch
5 times, most recently
from
January 3, 2024 14:54
47f1434
to
f4ca47b
Compare
ctrlc03
force-pushed
the
refactor/crypto-cleanup
branch
from
January 3, 2024 16:48
f4ca47b
to
133f0ef
Compare
0xmad
reviewed
Jan 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ctrlc03 thanks, just few comments
ctrlc03
force-pushed
the
refactor/crypto-cleanup
branch
from
January 5, 2024 16:35
133f0ef
to
d50f93e
Compare
ctrlc03
force-pushed
the
refactor/crypto-cleanup
branch
from
January 5, 2024 16:39
d50f93e
to
dcd1bb3
Compare
kittybest
reviewed
Jan 5, 2024
ctrlc03
force-pushed
the
refactor/crypto-cleanup
branch
from
January 5, 2024 17:16
dcd1bb3
to
7475fd4
Compare
0xmad
approved these changes
Jan 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ctrlc03 thanks!
…eparating classes and functions
ctrlc03
force-pushed
the
refactor/crypto-cleanup
branch
from
January 5, 2024 17:50
7475fd4
to
ed85bc5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
improve the organization of the package by further separating classes and functions
Confirmation