Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(crypto): improve package structure #935

Merged
merged 1 commit into from
Jan 5, 2024
Merged

Conversation

ctrlc03
Copy link
Collaborator

@ctrlc03 ctrlc03 commented Dec 18, 2023

Description

improve the organization of the package by further separating classes and functions

Confirmation

@ctrlc03 ctrlc03 self-assigned this Dec 18, 2023
Copy link

netlify bot commented Dec 18, 2023

Deploy Preview for maci-typedoc ready!

Name Link
🔨 Latest commit ed85bc5
🔍 Latest deploy log https://app.netlify.com/sites/maci-typedoc/deploys/6598416cd7dc420008b8105d
😎 Deploy Preview https://deploy-preview-935--maci-typedoc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ctrlc03 ctrlc03 force-pushed the refactor/crypto-cleanup branch 2 times, most recently from de77192 to d9d9b58 Compare December 29, 2023 11:58
@ctrlc03 ctrlc03 force-pushed the refactor/crypto-cleanup branch 5 times, most recently from 47f1434 to f4ca47b Compare January 3, 2024 14:54
@ctrlc03 ctrlc03 requested a review from 0xmad January 3, 2024 15:24
@ctrlc03 ctrlc03 force-pushed the refactor/crypto-cleanup branch from f4ca47b to 133f0ef Compare January 3, 2024 16:48
Copy link
Collaborator

@0xmad 0xmad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ctrlc03 thanks, just few comments

crypto/ts/hashing.ts Outdated Show resolved Hide resolved
crypto/ts/hashing.ts Outdated Show resolved Hide resolved
crypto/ts/hashing.ts Outdated Show resolved Hide resolved
@ctrlc03 ctrlc03 force-pushed the refactor/crypto-cleanup branch from 133f0ef to d50f93e Compare January 5, 2024 16:35
@ctrlc03 ctrlc03 requested a review from 0xmad January 5, 2024 16:35
@ctrlc03 ctrlc03 force-pushed the refactor/crypto-cleanup branch from d50f93e to dcd1bb3 Compare January 5, 2024 16:39
@ctrlc03 ctrlc03 force-pushed the refactor/crypto-cleanup branch from dcd1bb3 to 7475fd4 Compare January 5, 2024 17:16
Copy link
Collaborator

@0xmad 0xmad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ctrlc03 thanks!

@ctrlc03 ctrlc03 force-pushed the refactor/crypto-cleanup branch from 7475fd4 to ed85bc5 Compare January 5, 2024 17:50
@ctrlc03 ctrlc03 requested a review from kittybest January 5, 2024 17:50
@ctrlc03 ctrlc03 merged commit 16f5205 into dev Jan 5, 2024
12 checks passed
@ctrlc03 ctrlc03 deleted the refactor/crypto-cleanup branch January 5, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants