Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(contracts): refactor and add unit tests to the current suite #940

Merged
merged 1 commit into from
Jan 3, 2024
Merged

test(contracts): refactor and add unit tests to the current suite #940

merged 1 commit into from
Jan 3, 2024

Conversation

ctrlc03
Copy link
Collaborator

@ctrlc03 ctrlc03 commented Dec 22, 2023 •
edited
Loading

Description

Refactor of the current test suite and more test cases to ensure the smart contracts work as expected.

Note that topup tests will be added as part of tackling issue #923

Related issue(s)

fix #927

Confirmation

@netlify Netlify
Copy link

netlify bot commented Dec 22, 2023 •
edited
Loading

✅ Deploy Preview for maci-typedoc ready!

Name Link
🔨 Latest commit 32c3485
🔍 Latest deploy log https://app.netlify.com/sites/maci-typedoc/deploys/659580e7324dd4000932fe3f
😎 Deploy Preview https://deploy-preview-940--maci-typedoc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ctrlc03 ctrlc03 self-assigned this Dec 22, 2023
@ctrlc03 ctrlc03 added the testing Issue/PR related to tests label Dec 22, 2023
@ctrlc03 ctrlc03 force-pushed the test/contracts branch 3 times, most recently from 5ec6ebf to 641a855 Compare December 22, 2023 21:02
@ctrlc03 ctrlc03 marked this pull request as ready for review December 22, 2023 21:02
@ctrlc03 ctrlc03 force-pushed the test/contracts branch 6 times, most recently from 5b5bfe2 to aeced46 Compare January 2, 2024 17:38
@ctrlc03 ctrlc03 requested review from kittybest and 0xmad January 2, 2024 17:40
0xmad
0xmad requested changes Jan 2, 2024
View reviewed changes
Copy link
Collaborator

@0xmad 0xmad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ctrlc03 thanks, just few suggestions.

contracts/tests/MACI.test.ts Outdated Show resolved Hide resolved
contracts/tests/Poll.test.ts Outdated Show resolved Hide resolved
contracts/tests/PollFactory.test.ts Outdated Show resolved Hide resolved
contracts/ts/deploy.ts Outdated Show resolved Hide resolved
@ctrlc03 ctrlc03 requested a review from 0xmad January 3, 2024 09:42
0xmad
0xmad reviewed Jan 3, 2024
View reviewed changes
contracts/tests/MACI.test.ts Outdated Show resolved Hide resolved
contracts/tests/MACI.test.ts Outdated Show resolved Hide resolved
@ctrlc03 ctrlc03 requested a review from 0xmad January 3, 2024 15:11
0xmad
0xmad approved these changes Jan 3, 2024
View reviewed changes
Copy link
Collaborator

@0xmad 0xmad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ctrlc03 thanks!

@ctrlc03 ctrlc03 merged commit d1e1f74 into dev Jan 3, 2024
12 checks passed
@ctrlc03 ctrlc03 deleted the test/contracts branch January 3, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xmad 0xmad 0xmad approved these changes

@kittybest kittybest Awaiting requested review from kittybest kittybest is a code owner

Assignees

@ctrlc03 ctrlc03

Labels
testing Issue/PR related to tests
Projects
MACI
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Smart contracts unit tests
2 participants
@ctrlc03 @0xmad