Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(topup): implement test cases for the topup feature #952

Merged
merged 1 commit into from
Jan 5, 2024
Merged

Conversation

ctrlc03
Copy link
Collaborator

@ctrlc03 ctrlc03 commented Jan 5, 2024

Description

Implement test cases across the codebase for the topup feature.

Related issue(s)

Re: #923

Confirmation

@ctrlc03 ctrlc03 requested review from kittybest and 0xmad January 5, 2024 16:19
Copy link

netlify bot commented Jan 5, 2024

Deploy Preview for maci-typedoc ready!

Name Link
🔨 Latest commit 7775a8b
🔍 Latest deploy log https://app.netlify.com/sites/maci-typedoc/deploys/65985b6d79ca91000844d711
😎 Deploy Preview https://deploy-preview-952--maci-typedoc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ctrlc03 ctrlc03 self-assigned this Jan 5, 2024
@ctrlc03 ctrlc03 added this to the MACI v1.1.1 refactor milestone Jan 5, 2024
Copy link
Collaborator

@0xmad 0xmad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ctrlc03 thanks, just few code style comments.

cli/tests/e2e.test.ts Outdated Show resolved Hide resolved
contracts/tests/Poll.test.ts Show resolved Hide resolved
cli/test.sh Outdated Show resolved Hide resolved
@ctrlc03 ctrlc03 force-pushed the test/topup branch 2 times, most recently from 8e3f2e8 to 0d53c0f Compare January 5, 2024 17:47
@ctrlc03 ctrlc03 requested a review from 0xmad January 5, 2024 17:48
cli/tests/e2e.test.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@0xmad 0xmad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ctrlc03 thanks!

@ctrlc03 ctrlc03 merged commit c47dd04 into dev Jan 5, 2024
12 checks passed
@ctrlc03 ctrlc03 deleted the test/topup branch January 5, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants