Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(core): test refactoring and implementation #954

Merged
merged 1 commit into from
Jan 8, 2024
Merged

test(core): test refactoring and implementation #954

merged 1 commit into from
Jan 8, 2024

Conversation

ctrlc03
Copy link
Collaborator

@ctrlc03 ctrlc03 commented Jan 5, 2024

Description

Refactor and add tests to the core package.

Blocked by #953

Related issue(s)

re: #792

Confirmation

Copy link

netlify bot commented Jan 5, 2024

Deploy Preview for maci-typedoc ready!

Name Link
🔨 Latest commit 4aedb83
🔍 Latest deploy log https://app.netlify.com/sites/maci-typedoc/deploys/659c2264e9c5b10008d467fb
😎 Deploy Preview https://deploy-preview-954--maci-typedoc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ctrlc03 ctrlc03 changed the title Test/core test(core): test refactoring and implementation Jan 5, 2024
@ctrlc03 ctrlc03 self-assigned this Jan 5, 2024
@ctrlc03 ctrlc03 added this to the MACI v1.1.1 refactor milestone Jan 6, 2024
@ctrlc03 ctrlc03 marked this pull request as ready for review January 6, 2024 00:05
@ctrlc03 ctrlc03 force-pushed the test/core branch 2 times, most recently from fd53e75 to d4f9860 Compare January 6, 2024 00:09
@ctrlc03 ctrlc03 requested review from 0xmad and kittybest January 6, 2024 00:09
Copy link
Collaborator

@0xmad 0xmad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ctrlc03 thanks!

@ctrlc03 ctrlc03 merged commit 1f1fd0a into dev Jan 8, 2024
13 checks passed
@ctrlc03 ctrlc03 deleted the test/core branch January 8, 2024 16:47
@ctrlc03 ctrlc03 mentioned this pull request Jan 9, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants