Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(integration): ensure integration tests are using the correct user keys #957

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

ctrlc03
Copy link
Collaborator

@ctrlc03 ctrlc03 commented Jan 8, 2024

Description

Ensure integration tests use the correct user keys, in particular when performing key changes.

Related issue(s)

re: #910

Confirmation

@ctrlc03 ctrlc03 requested review from kittybest and 0xmad January 8, 2024 14:33
@ctrlc03 ctrlc03 self-assigned this Jan 8, 2024
@ctrlc03 ctrlc03 added the testing Issue/PR related to tests label Jan 8, 2024
Copy link

netlify bot commented Jan 8, 2024

Deploy Preview for maci-typedoc ready!

Name Link
🔨 Latest commit 5b6aa92
🔍 Latest deploy log https://app.netlify.com/sites/maci-typedoc/deploys/659c2ba02ced510008d34920
😎 Deploy Preview https://deploy-preview-957--maci-typedoc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@0xmad 0xmad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ctrlc03 thanks, just one minor suggestion.

integrationTests/ts/__tests__/integration.test.ts Outdated Show resolved Hide resolved
@ctrlc03 ctrlc03 merged commit c48e653 into dev Jan 8, 2024
13 checks passed
@ctrlc03 ctrlc03 deleted the test/integration branch January 8, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Issue/PR related to tests
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants