Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): enable environmental variables #996

Merged
merged 1 commit into from
Jan 11, 2024
Merged

feat(cli): enable environmental variables #996

merged 1 commit into from
Jan 11, 2024

Conversation

kittybest
Copy link
Collaborator

@kittybest kittybest commented Jan 11, 2024 •
edited
Loading

Description

  • Add ETH_PROVIDER in the .env.template file.
  • import dotenv package to enable hardhat.config.ts to read environmental variables.

Related issue(s)

close issue #995.

Confirmation

@kittybest kittybest requested review from 0xmad and ctrlc03 January 11, 2024 14:53
@kittybest kittybest requested a review from samajammin as a code owner January 11, 2024 14:53
@netlify Netlify
Copy link

netlify bot commented Jan 11, 2024 •
edited
Loading

✅ Deploy Preview for maci-typedoc ready!

Name Link
🔨 Latest commit a206df1
🔍 Latest deploy log https://app.netlify.com/sites/maci-typedoc/deploys/65a000f67a60830008a92733
😎 Deploy Preview https://deploy-preview-996--maci-typedoc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

ctrlc03
ctrlc03 approved these changes Jan 11, 2024
View reviewed changes
Copy link
Collaborator

@ctrlc03 ctrlc03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@ctrlc03 ctrlc03 merged commit 0689040 into dev Jan 11, 2024
14 checks passed
@ctrlc03 ctrlc03 deleted the feat/cli-env-file branch January 11, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctrlc03 ctrlc03 ctrlc03 approved these changes

@0xmad 0xmad Awaiting requested review from 0xmad 0xmad is a code owner

@samajammin samajammin Awaiting requested review from samajammin

Assignees

@kittybest kittybest

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kittybest @ctrlc03