feat: Probot v11 #59
Merged
feat: Probot v11 #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: The package was renamed from `@probot/serverless-lambda` to `@probot/adapter-aws-lambda-serverless` for consistency with the other adapters
BREAKING CHANGE: Usage changed
Before
```js
// handler.js
const { serverless } = require("@probot/serverless-lambda");
const appFn = require("./");
module.exports.probot = serverless(appFn);
```
After
```js
const { createLambdaFunction, createProbot } = require("@probot/adapter-aws-lambda-serverless");
const appFn = require("./");
module.exports.webhooks = createLambdaFunction(appFn, { probot: createProbot() });
```
This was referenced Feb 9, 2021
This was referenced Feb 9, 2021
oscard0m
reviewed
Feb 10, 2021
| @@ -1,54 +1,37 @@ | |||
| { | |||
| "name": "@probot/serverless-lambda", | |||
| "name": "@probot/adapter-aws-lambda-serverless", | |||
There was a problem hiding this comment.
npm question: Does this mean the old name will disappear from registry? I mean, @probot/[email protected] won't exist anymore?
There was a problem hiding this comment.
not disappear, but it will be deprecated
oscard0m
approved these changes
Feb 10, 2021
lambda-function.js
Outdated
| // Ends function immediately after callback | ||
| context.callbackWaitsForEmptyEventLoop = false; | ||
|
|
||
| // this could will be simpler once we ship `verifyAndParse()` |
tcbyrd
approved these changes
Feb 10, 2021
|
|
||
| return { | ||
| statusCode: error.status || 500, | ||
| error: "ooops", |
There was a problem hiding this comment.
Could this be more helpful? For example maybe point users at docs for Cloudwatch logs on how to debug?
There was a problem hiding this comment.
I'm not sure how? By adding a "documentation_url" key to the response? I'll create a follow up issue for further discussion to unblock this PR for now
Co-authored-by: Tommy Byrd <[email protected]>
gr2m
commented
Feb 10, 2021
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #10
fixes #11
closes #24
fixes #25
fixes #36
fixes #39
fixes #54
fixes #58
BREAKING CHANGE: The package was renamed from
@probot/serverless-lambdato@probot/adapter-aws-lambda-serverlessfor consistency with the other adaptersBREAKING CHANGE: Usage changed
Before
After
View rendered README.md