-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support Probot v13 #128
Conversation
@gr2m if you have a moment could you have a peak at this? 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey thanks for that! I didn't test it but I'm going to trust you on this one 👍🏼
Hmm I'm okay with dropping the tests for node 14 & 16 and test in 20 and 22 instead Do you know what node version lambda is using? |
@gr2m judging by https://docs.aws.amazon.com/lambda/latest/dg/lambda-runtimes.html it looks like: 20 - No Planned Deprecation I would need to look into the specifics to get 16 to work or would you prefer to go with just 18 & 20?
|
great, thanks for checking! Can you update the test matrix as part of this PR? adapter-aws-lambda-serverless/.github/workflows/test.yml Lines 15 to 17 in 1eb30a0
|
Thanks for the advice @gr2m I've done that! Looks like Probot has dropped support for anything below 18 probot/probot@948a1b7 I realise I haven't tested in 22, I left it out because it's not a supported AWS version, however I see sense in adding it in as a future proofing mechanism. |
That's okay, we can add it later |
🎉 This PR is included in version 4.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This PR updates Probot to v13 and replaces nock with fetch-mock.
When attempting to use this package with other packages including functionality built around newer webhook events I came across issues with mismatching
@octokit/webhooks-types
(or just@octokit/wehooks
)As per octokit/core.js#551 it is recommended to capture outgoing fetch requests using
fetch-mock
overnock
.I have dropped out the dependency for
@probot/get-private-key
as this is not directly used within this package anymore.