A small collection of fixes #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 5, 2020 07:05
When the `done` function was removed in probot#18, the tests were not updated
This will fix probot#34 by setting a default value on the `lowerCaseKeys` function. You can get into this state when setting up a test/demo incorrectly or using a lambda warmer (like serverless-warmup). I am immediately returning because then a clear error can be shown.
Continues work started in probot#18
gr2m
reviewed
Nov 5, 2020
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two main things in here:
lowerCaseKeysbecause it is possible to send in an event without headers. In production, we saw this occurring withserverless-warmupplugin sending no headers.done()usage(High-fives to @maumercado for finding and suggesting the fix in
lowerCaseKeys)