Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Headers insensitive #66

Merged
merged 3 commits into from
Feb 25, 2021
Merged

Headers insensitive #66

merged 3 commits into from
Feb 25, 2021

Conversation

axel3rd
Copy link
Contributor

@axel3rd axel3rd commented Feb 23, 2021 •
edited by gr2m
Loading

fixes #62

@axel3rd axel3rd marked this pull request as draft February 23, 2021 19:23
gr2m
gr2m reviewed Feb 23, 2021
View reviewed changes
Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests look good so far 👍🏼

test/index.test.js Outdated Show resolved Hide resolved
@axel3rd axel3rd marked this pull request as ready for review February 24, 2021 18:27
@axel3rd
Copy link
Contributor Author

axel3rd commented Feb 24, 2021 •
edited by unfurl-links bot
Loading

NB: package-lock.json not commited, I'm NOT on https://registry.npmjs.org endpoint => pollution with different URL (on lowercase-keys package)

gr2m
gr2m approved these changes Feb 25, 2021
View reviewed changes
Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

lambda-function.js
async function lambdaFunction(probot, event, context) {
try {
// Ends function immediately after callback
context.callbackWaitsForEmptyEventLoop = false;

// lowercase all headers to respect headers insensitivity (RFC 7230 $3.2 'Header Fields', see issue #62)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding the comment & referencing the issue 👍🏼

@gr2m gr2m merged commit 96ced73 into probot:master Feb 25, 2021
@github-actions
Copy link

🎉 This PR is included in version 2.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@axel3rd axel3rd deleted the headers-insensitive branch February 25, 2021 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gr2m gr2m gr2m approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Headers case-insensitivity
2 participants
@axel3rd @gr2m