Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't Call JSON.parse on event.body #89

Merged
merged 1 commit into from
Mar 9, 2022
Merged

Don't Call JSON.parse on event.body #89

merged 1 commit into from
Mar 9, 2022

Commits on Mar 9, 2022

  1. Don't Call JSON.parse on event.body 

    Fixes probot#78.

This PR removes the `JSON.parse` call from `event.body`. This was causing issues when trying to invoke Lambda functions asynchronously with `async` set to `true` in a `serverless.yaml` config file. I'm not exactly sure why this doesn't cause issues when `async` is not set to `true`, but I tested these changes with `http` events (both `async: true` and `async: false`) and `httpApi` events and it seemed to work fine on both. Also, I believe the `verifyAndReceive` function internally handles both objects and strings anyway.
    @ajschmidt8
    ajschmidt8 committed Mar 9, 2022
    Configuration menu
    Copy the full SHA
    34ce9e9 View commit details
    Browse the repository at this point in the history