Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deepmerge by default #263

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Jul 21, 2024

BREAKING CHANGE: Use @fastify/deepmerge to deepmerge configurations
BREAKING CHANGE: defaults option does not accept a merge function anymore
BREAKING CHANGE: adding new merge option, which can be used to override the the default merge strategy

BREAKING CHANGE: Use @fastify/deepmerge to deepmerge configurations
BREAKING CHANGE: defaults option does not accept a merge function anymore
BREAKING CHANGE: adding new merge option, which can be used to override the the default merge strategy
@Uzlopak
Copy link
Contributor Author

Uzlopak commented Jul 21, 2024

hmm, maybe it is already implemented on probot level. maybe should be implemented on this level.
But on probot level it seems to be broken?!

https://github.com/probot/probot/blob/ae034152d98e2ad5968d40d799082e96cc84ef5a/src/context.ts#L234

GitHub
🤖 A framework for building GitHub Apps to automate and improve your workflow - probot/probot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant