Update design #367
Update design #367
Conversation
|
Thank you for all your contributions @AaronDewes. https://probot.github.io/ really needs some love!
I think the preview is there, but the assets are loaded with a Unfortunately I cannot manage to set up the jekyll locally,
|
How about Gatsby? I can try to implement it if you want. |
|
Gatsby might be overkill? And I'm not very familiar with it, it looks rather complex and I'd be nervous that we wouldn't be able to maintain it when you move on to other projects. But if you think it's simple enough and you would like to give it a try to convince us, please feel free :) As an alternative suggestion: are you familiar with https://www.11ty.dev/?
|
|
Not really familiar with it, but I can try it the day after tomorrow if you want. |
|
Another option is next.js, which might be a bit more complicated, but it would permit us to easily add dynamically generated pages later you choice! I'm a bit familiar with 11ty and next.js, these would be my preferences, but feel free to give Gatsby a go |
|
Next.js isn't optimized for GitHub pages though, it's better for vercel. But I have a bit of next experience, so I might try it. I'll create some concepts the day after tomorrow. |
|
11ty is the most similar to Jekyll in the Node space. My vote would be that since it doesn't introduce any React dependencies, and since Pages doesn't really have the best experience today with SPA frameworks like Gatsby and Next. |
|
okay lets do 11ty then, okay @AaronDewes? I'd be open to experiment with next.js in future if the need for dynamic page rendering comes up. We will of course need to change the domain then to something like probot.dev, but let's take one step at a time |
|
|
|
@gr2m This would require changes to the main probot repo because Jekyll and 11ty work slightly different and there are some issues with the docs. Would that be okay for you? |
|
Apps & docs not working, but https://probot-testsite.github.io/ |
yes, let me know what we need to change
😍 |
|
PR to the main repo is open, https://probot-testsite.github.io/ has been updated. After successfully merging this PR (#367), you need to change the github pages branch from master to gh-pages. But please note that after probot/probot#1516, I still need to do some minor changes, updating the submodule & removing the docs folder from .eleventyignore. |
|
I still need to fix the docs, but it's nearly finished. |
This is a separate commit to make reviewing easier, no real changes have been done here except removing that folder
- Updated all data - Fixed slug for rezensent and untrivializer Again, a separate commit for this should hopefully make reviewing easier
This is the most interesting commit about the 11ty port, where all changes have been dome
|
Just force-pushed to make the review a bit easier: commit 99072ea contains all the important changes, the other two only autogenerated, but big changes |
|
@gr2m It's getting late here, but probot-testsite seems to work now (except the things you said can be done in a follow-up PR), so you can merge this if you want, I'll do follow-up work tomorrow |
|
No, it's not working, all doc examples are one line right now, I'll do it tomorrow then |
|
@gr2m It should be ready now, can you have a look again? |
|
New page is now deployed to and served from the If you like we could deploy to Netlify to get the previews on PRs? |
A preview should be available at https://aarondewes.github.io/probot.github.io soon, not sure how long GitHub pages takes to make it available. This updates primer, introduces dark mode and makes some minor tweaks to the design
View rendered node_modules/@primer/css/CHANGELOG.md
View rendered node_modules/@primer/css/README.md
View rendered node_modules/@primer/css/alerts/README.md
View rendered node_modules/@primer/css/autocomplete/README.md