Make package compatible with probot v10 #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gr2m
reviewed
Sep 17, 2020
There was a problem hiding this comment.
Looks good 👍🏼 Did you have a chance to test if it still works /cc @soberstadt
| const { findPrivateKey } = require('probot/lib/private-key') | ||
| const { Probot } = require('probot') | ||
| const { resolve } = require('probot/lib/helpers/resolve-app-function') | ||
| const { findPrivateKey } = require('probot/lib/helpers/get-private-key') |
There was a problem hiding this comment.
I'm not happy that we use internal APIs, I'll see if we can make these methods official exports at the root level so things won't break if Probot's internal file structure changes.
|
I'm trying to test it on AWS but I'm dealing with a problem with my account. Hopefully I will be able to test it over the weekend :) |
|
I tested this on my probot and it worked 🎉 |
|
Awesome!! Glad to hear that! |
|
Sweet, thank you for checking! |
gr2m
force-pushed
the
update-probot-v10
branch
from
92c58a5
to
a4ba944
Compare
gr2m
pushed a commit
that referenced
this pull request
Sep 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR adds compatibility with probot v10.
Credits on @soberstadt
resolves #43