Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Getting Stated in WebGL' section translated to hindi #1434

Merged
merged 2 commits into from
Nov 9, 2023
Merged

'Getting Stated in WebGL' section translated to hindi #1434

merged 2 commits into from
Nov 9, 2023

Conversation

ar-rana
Copy link
Contributor

@ar-rana ar-rana commented Nov 4, 2023

Fixes #1431

Changes:
I added the Hindi translation to the learn page on the 'Getting started with WebGL' section. The section and its sub-heading were not transalted to hindi.

Screenshots of the change:
Before:
Screenshot 2023-11-04 150524
After Changes:
Screenshot 2023-11-04 150544

src/data/hi.yml Outdated
@@ -651,10 +651,10 @@ learn:
getting-started-in-webgl-other-tutorials-tut3: Styling and Appearance
getting-started-in-webgl-other-tutorials-tut4: Introduction to Shaders
getting-started-in-webgl-other-tutorials-you-are-here: (you are here)
getting-started-in-webgl-title: Getting Started in WebGL
getting-started-in-webgl-title: WebGL में शुरूवाती कदम
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please translate "WebGL" also.

Same corrections everywhere

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, will do it by today

Copy link
Contributor Author

@ar-rana ar-rana Nov 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ranaaditya the requested changes have been made, also translated the rest of the section;
Screenshot 2023-11-05 115104

@ar-rana ar-rana requested a review from ranaaditya November 5, 2023 06:22
Copy link
Member

@ranaaditya ranaaditya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@limzykenneth limzykenneth reopened this Nov 9, 2023
@limzykenneth limzykenneth merged commit cb591bd into processing:main Nov 9, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'Getting Started in WebGL' Subheading Not Translated to Hindi
3 participants