textToPoints not working with letter "B" from Google Font

[pifragile]

Most appropriate sub-area of p5.js?

• Accessibility (Web Accessibility)
• Build tools and processes
• Color
• Core/Environment/Rendering
• Data
• DOM
• Events
• Friendly error system
• Image
• IO (Input/Output)
• Localization
• Math
• Unit Testing
• Typography
• Utilities
• WebGL
• Other (specify if possible)

Details about the bug:

• p5.js version: 1.4.0
• Web browser and version:Chrome 94.0.4606.81
• Operating System: MacOSX
• Steps to reproduce this:

I loaded the Google Font "Dancing Script" and used textToPoints on it. It works well for all letters, but with letter "B" no points are returned. When simply using "text" with the same font, the letter "B" prints as expected. So i suppose it is not a problem with the font.

Please refer to https://editor.p5js.org/pifragile/sketches/l0JS6TCks. It is all setup there. You can take a look at the console output and you can see that for letter "B" an empty array of points is returned.

[welcome]

Welcome! 👋 Thanks for opening your first issue here! And to ensure the community is able to respond to your issue, be sure to follow the issue template if you haven't already.

[dhowe]

The should be resolved with #5466

Explanation: the issue here is the final line of the isSpace() function which checks that the glyph's index is not the literal number 3. I'm not sure why this was originally included in the code (there is no comment), but I have run all the tests without it and see no adverse affects. It is likely however that there was a valid reason for including it originally, so we should keep an eye out for problems its removal may cause. I've also fixed some tests which were broken when fonts were moved around.

function isSpace(i) {
  return (
    (glyphs[i].name && glyphs[i].name === 'space') ||
    (txt.length === glyphs.length && txt[i] === ' ') ||
    (glyphs[i].index && glyphs[i].index === 3) // PR removes this line
  );
}

[limzykenneth]

@dhowe I found that the function came from #2108, do you recall why the checks are written that way?

[dhowe]

yes, I also looked up that commit -- but no idea where that index check came from

[dhowe]

it occurs to me that we may need to handle other types of whitespace in that function, let me do a few more tests before we merge

[dhowe]

So this is fine with single or multiple spaces, including tabs, and can be merged as is
I do notice a possible issue with line breaks, but have created a new ticket for this (#5474)

[limzykenneth]

Fixed by #5466