Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in JSDoc of the createVector method #6569

Closed
cabbage63 opened this issue Nov 20, 2023 · 4 comments · Fixed by #6574
Closed

Typo in JSDoc of the createVector method #6569

cabbage63 opened this issue Nov 20, 2023 · 4 comments · Fixed by #6574
Assignees
@cabbage63
Labels
Discussion

Comments

@cabbage63
Copy link
Contributor

cabbage63 commented Nov 20, 2023 •
edited
Loading

Topic

I found a typo in the JSDoc of createVector method in src/math/math.js.
It seems to have an effect on p5.js web reference. (Unnecessary backquote is printed.)
If you don't mind, I'll create a pull request for this issue.

https://github.com/processing/p5.js/blob/main/src/math/math.js#L24

image
@welcome Welcome
Copy link

welcome bot commented Nov 20, 2023

Welcome! 👋 Thanks for opening your first issue here! And to ensure the community is able to respond to your issue, please make sure to fill out the inputs in the issue forms. Thank you!

@nickmcintyre
Copy link
Member

Good catch @cabbage63. Please feel free to open the pull request!

cabbage63 added a commit to cabbage63/p5.js that referenced this issue Nov 21, 2023
@cabbage63
Fix typo in JSDoc of the createVector method processing#6569
12491a4
@cabbage63 cabbage63 mentioned this issue Nov 21, 2023
Merged
3 tasks
@cabbage63
Copy link
Contributor Author

@nickmcintyre
Thank you.
I've created a PR to fix this issue.
Please check that when you have time.

#6574

nickmcintyre added a commit that referenced this issue Nov 21, 2023
@nickmcintyre
Merge pull request #6574 from cabbage63/fix-typo-in-jsdoc
cab0ff1 
Fix typo in JSDoc of the createVector method #6569
@nickmcintyre
Copy link
Member

Nice work @cabbage63!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cabbage63 cabbage63

Labels
Discussion
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix typo in JSDoc of the createVector method #6569 cabbage63/p5.js
2 participants
@nickmcintyre @cabbage63