Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust Option Orientation in CreateRadio() reference. #7366

Closed
1 of 17 tasks
perminder-17 opened this issue Nov 7, 2024 · 5 comments · Fixed by #7367
Closed
1 of 17 tasks

Adjust Option Orientation in CreateRadio() reference. #7366

perminder-17 opened this issue Nov 7, 2024 · 5 comments · Fixed by #7367
Assignees
@devesh-2002
Labels
Area:DOM Bug Documentation Good First Issue

Comments

@perminder-17
Copy link
Contributor

Most appropriate sub-area of p5.js?

  • Accessibility
  • Color
  • Core/Environment/Rendering
  • Data
  • DOM
  • Events
  • Image
  • IO
  • Math
  • Typography
  • Utilities
  • WebGL
  • Build process
  • Unit testing
  • Internationalization
  • Friendly errors
  • Other (specify if possible)

p5.js version

No response

Web browser and version

No response

Operating system

No response

Steps to reproduce this

Steps:

  1. Go to link : https://p5js.org/reference/p5/createRadio/
  2. See the reference

In PR #7315 we noticed,

image

A proper alignment would be nice to have.
@devesh-2002
Copy link

Hi. May I take this issue?

@perminder-17
Copy link
Contributor Author

Hi. May I take this issue?

Sure, I'll assign you.

@Prajyot05
Copy link
Contributor

Prajyot05 commented Nov 8, 2024 •
edited
Loading

@perminder-17 I have solved the issue, should I raise my PR? @devesh-2002 are you facing any issue?
Here's how it looks:
Screenshot 2024-11-08 at 3 26 57 PM

Prajyot05 added a commit to Prajyot05/p5.js that referenced this issue Nov 8, 2024
@Prajyot05
fixes issue processing#7366
ef009fd
@Prajyot05 Prajyot05 mentioned this issue Nov 8, 2024
Merged
3 tasks
@devesh-2002
Copy link

Hi @Prajyot05 , you can take this issue if you have already worked on it.

@Prajyot05
Copy link
Contributor

@devesh-2002 alright, thanks

davepagurek added a commit that referenced this issue Nov 25, 2024
@davepagurek
Merge pull request #7367 from Prajyot05/fix/#7366
bf41e90 
fixes issue #7366: Adjust Option Orientation in CreateRadio() reference.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@devesh-2002 devesh-2002

Labels
Area:DOM Bug Documentation Good First Issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixes issue #7366: Adjust Option Orientation in CreateRadio() reference. Prajyot05/p5.js
3 participants
@devesh-2002 @perminder-17 @Prajyot05