Improve clarity of lightFalloff()
example
#5315
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current example, the translations to place the spheres are done globally (instead of using
push
andpop
). As a result, the light positions are affected by these translations.As a consequence of this, the color of the rightmost sphere is affected more by the light position than by falloff.
This is what the two spheres look like in the current example if the lines setting
lightFalloff()
are commented out:What should happen instead is that both spheres are equally lit. Here is what they look like with
lightFalloff()
commented out in the proposed example:In the proposed changes (live version here), the difference between the two spheres becomes attributable to falloff only.
Change as docs: