Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace deprecated String.prototype.substr() #5643

Merged
merged 1 commit into from
Apr 22, 2022
Merged

refactor: replace deprecated String.prototype.substr() #5643

merged 1 commit into from
Apr 22, 2022

Conversation

CommanderRoot
Copy link
Contributor

String.prototype.substr() is deprecated so we replace it with String.prototype.slice() which works similarily but isn't deprecated.
.substr() probably isn't going away anytime soon but the change is trivial so it doesn't hurt to do it.

PR Checklist

.substr() is deprecated so we replace it with .slice() which works similarily but isn't deprecated

Signed-off-by: Tobias Speicher <[email protected]>
@welcome
Copy link

welcome bot commented Mar 24, 2022

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. And be sure to add yourself to the list of contributors on the readme page!

@montoyamoraga
Copy link
Member

@all-contributors please add @CommanderRoot for code

@allcontributors
Copy link
Contributor

@montoyamoraga

I've put up a pull request to add @CommanderRoot! 🎉

@limzykenneth limzykenneth merged commit 0c188f4 into processing:main Apr 22, 2022
@limzykenneth
Copy link
Member

Looks good. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants