Fix tint() for p5.MediaElement #5871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. Thanks! |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5868
Past me took out this call to
loadPixels()forp5.MediaElements because I thought it was just populating thepixelsarray, which the new tint implementation no longer needs. However, it was also ensuring that they have acanvasproperty with a screenshot of the current frame in it, whichtint()does need.This ensures that tinted
p5.MediaElements have a canvas (without the overhead of loading pixels), which allows them to work with the new tint implementation rather than returning early.Screenshots of the change:
Tinting the webcam works again!
Live version: https://editor.p5js.org/davepagurek/sketches/Owc30NXkE
PR Checklist
npm run lintpasses