fixes the semitransparent stroke disabled #5985
Conversation
|
I don't understand why the warning is needed when it should just allow transparency changes. |
|
@inaridarkfox4231 I thought it would be better if the user would know that little detail . I will push the changes right away. |
There was a problem hiding this comment.
Just some small cleanup, otherwise this is good to go!
We might want to consider making a follow-up issue to address the behaviour strokes overlapping with each other at corners though. Here's a rectangle:
...but even without that solved, this should still enable people to draw single lines with transparency!
src/webgl/p5.RendererGL.js
Outdated
| console.warn( | ||
| 'Default opaque stroke is used if not the optional fourth argument is not specified in stroke method'); | ||
| } | ||
| // arguments[3]=255; |
There was a problem hiding this comment.
We aren't using this line any more right? We can take this out too for readability
src/webgl/p5.RendererGL.js
Outdated
| arguments[3] = 255; | ||
| // @todo allow transparency in stroking currently doesn't have | ||
| // any impact and causes problems with specularMaterial | ||
| if(arguments[3]===undefined){ |
There was a problem hiding this comment.
Super tiny formatting change, but mind adding spacing around the === operator to better match the formatting elsewhere in the codebase?
There was a problem hiding this comment.
Oh I think we can also take out that @todo comment too. This doesn't seem to affect specularMaterial any more (aside from the stroke joint blending issues I mentioned earlier, which we can address separately.)
|
@davepagurek please review this |
Resolves #5951
Changes:
fixed the stroke method . previously it was using the default opaque strokes even if changed by the user
PR Checklist
npm run lintpasses