Omit processing to the 4th argument in p5.js webgl stroke() #5989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Omit the process of setting the fourth argument to 255 in stroke(). Because it doesn't make sense.
davepagurek
approved these changes
Feb 1, 2023
|
thanks for merge! ('ω') |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Omit the process of setting the fourth argument to 255 in stroke(). Because it doesn't make sense.
Resolves #5988
Changes:
Even without setting the 4th argument to 255, for example, if there are 3 arguments, the 4th argument will automatically become the maximum transparency, so I thought this process was unnecessary.
PR Checklist
npm run lintpasses