Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My first pr to p5.js! 🎊 This pr doesn't provide a solution to issue #6013 or add any new functionality, it just fixes a bug I found.
I saw that the _frameRate and deltaTime values were calculated after
redraw()
but they should be calculated beforeredraw()
I also avoided subtracting the same values twice by putting the deltaTime calculation first.
See @davepagurek 's example sketches to see the fix in action.
Ball's speed doesn't not match when using
frameRate()
vsmillis()
:https://editor.p5js.org/davepagurek/sketches/K7cKw7bie
With the fix the balls' speeds match:
https://editor.p5js.org/davepagurek/sketches/VXHoBahkN