Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build output cleanup #6028

Merged
merged 2 commits into from
Feb 27, 2023
Merged

Build output cleanup #6028

merged 2 commits into from
Feb 27, 2023

Conversation

Ucodia
Copy link
Contributor

@Ucodia Ucodia commented Feb 22, 2023

Addresses #5114

Changes

First change upgrades simple-git package version replaces usage of require('simple-git/promise'') by require('simple-git') which fixes the following warning at the top of the build output:

=============================================
simple-git has supported promises / async await since version 2.6.0.
 Importing from 'simple-git/promise' has been deprecated and will
 report this error until the next major release of version 4.

To upgrade, change all 'simple-git/promise' imports to just 'simple-git'
=============================================

Second change upgrades the transitive dependency istanbul-reports from grunt-simple-nyc package which fixes the following warning at the bottom of the build output:

Handlebars: Access has been denied to resolve the property "statements" because it is not an "own property" of its parent.
You can add a runtime option to disable the check or this warning:
See https://handlebarsjs.com/api-reference/runtime-options.html#options-to-control-prototype-access for details
Handlebars: Access has been denied to resolve the property "branches" because it is not an "own property" of its parent.
You can add a runtime option to disable the check or this warning:
See https://handlebarsjs.com/api-reference/runtime-options.html#options-to-control-prototype-access for details
Handlebars: Access has been denied to resolve the property "functions" because it is not an "own property" of its parent.
You can add a runtime option to disable the check or this warning:
See https://handlebarsjs.com/api-reference/runtime-options.html#options-to-control-prototype-access for details
Handlebars: Access has been denied to resolve the property "lines" because it is not an "own property" of its parent.
You can add a runtime option to disable the check or this warning:
See https://handlebarsjs.com/api-reference/runtime-options.html#options-to-control-prototype-access for details

Screenshots of the change:

Not applicable.

PR Checklist

  • npm run lint passes

- Followed recommendation in warning
- Upgraded library
- Upgrade transitive dependency istanbul-reports from grunt-simple-nyc
@limzykenneth
Copy link
Member

We are not actually using those release scripts anymore and they along with simple-git can probably be removed. I'll merge this anyway for now though.

@limzykenneth limzykenneth merged commit 55460fd into processing:main Feb 27, 2023
@Ucodia
Copy link
Contributor Author

Ucodia commented Feb 27, 2023

@limzykenneth is there a task describing how the release process was transitioned? I can help with the cleanup.

@limzykenneth
Copy link
Member

The release process are all handled via Github Actions CI whenever a version tag is pushed. It is documented here: https://github.com/processing/p5.js/blob/main/contributor_docs/release_process.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants