Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make gif test less flaky #6090

Merged
merged 1 commit into from
Mar 24, 2023
Merged

Conversation

davepagurek
Copy link
Contributor

Resolves #6089

Changes:

  • Before, this test waited 100ms for a gif to go to the next frame, plus a bit extra to wait for a draw to happen
  • However, the draw doesn't reliably happen in that extra 10ms, causing tests to fail occasionally
  • Now it explicitly waits for the next frame instead of adding a bit of extra time to the timeout

Screenshots of the change:
N/A

PR Checklist

  • npm run lint passes
  • [Inline documentation] is included / updated
  • [Unit tests] are included / updated

@limzykenneth
Copy link
Member

I did notice this behaviour as well the other day, I think this fix should work as long as in the previous 100ms wait the gif has moved to the next frame. You can merge this when ready.

@davepagurek davepagurek merged commit 9ee0fa7 into processing:main Mar 24, 2023
@davepagurek davepagurek deleted the fix/flaky-gif-test branch March 24, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gif test case is flaky
2 participants