Updated documentation for shaders. #6497
Conversation
|
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. And be sure to add yourself to the list of contributors on the readme page! |
Co-authored-by: Dave Pagurek <[email protected]>
Co-authored-by: Dave Pagurek <[email protected]>
Co-authored-by: Dave Pagurek <[email protected]>
Co-authored-by: Dave Pagurek <[email protected]>
|
I have made these changes, please take a look. |
There was a problem hiding this comment.
One more change I think! Before, the createShader example was relying on the vertex shader to do the positioning, and was basically ignoring the position from p5, so the example uses quad(-1, -1, 1, -1, 1, 1, -1, 1);. Now, it actually ends up drawing a very tiny quad.
Maybe we can replace the quad() call with plane(width, height) to make a full-canvas shader? If you run grunt yui:dev after making the changes, it opens a local version of the docs so you can test how it looks.
|
Sure! Is it this example that you're talking about? (under createShader). |
|
Right, that's the one! |
|
does this look fine? |
|
hi, please have a look and let me know if other changes are required! |
|
It looks good in a browser now, thanks! The last thing is to get the automated tests to pass. Right now it looks like they're failing because some lines have trailing spaces at the end: It looks like after removing those we should be ok! |
|
Removed the trailing spaces! |
Resolves #4714
Changes:
Updated the createShader with vertex shader. To recommend users make use of this shader to avoid inconsistency in their code as shaders can change the positioning of shapes drawn with them.
Also updated related docs in loadShader and shader.
PR Checklist
npm run lintpasses