-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored the createGraphics function in rendering.js #6557
Merged
davepagurek
merged 7 commits into
processing:main
from
Jaivignesh-afk:enhancement-rendering-refact
Nov 21, 2023
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
25ce601
Refactored argument name for createGraphics
Jaivignesh-afk 5e43969
Revert "Refactored argument name for createGraphics"
Jaivignesh-afk 3b3a7e6
Enchanced readability for createGraphics in rendering.js
Jaivignesh-afk e9f4f6d
Refactored rendering.js
Jaivignesh-afk e0c0498
Merge branch 'processing:main' into enhancement-rendering-refact
Jaivignesh-afk d20e86b
Merge branch 'processing:main' into enhancement-rendering-refact
Jaivignesh-afk 3485168
done suggested changes
Jaivignesh-afk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this is a bug:
args[1]
will also beconstants.P2D
because you are setting it equal toargs[0]
after resetting that to beconstants.P2D
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Absolutely! I was thinking the same. Maybe using a temporary variable could do the trick? What do you reckon?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would work, or alternatively just setting
args[1]
beforeargs[0]
.