Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix syntax error re: new p5.Vector.cross #6640

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

lindapaiste
Copy link
Contributor

Fixes the failing tests explained in this comment:

All of the tests related to the camera _orbit method fail with TypeError: _main.default.Vector.cross is not a constructor because the code uses improper syntax new p5.Vector.cross(up, front). cross is a static method so there shouldn't be a new there.

Changes:

  • Replace syntax new p5.Vector.cross(a, b) with p5.Vector.cross(a, b) in a few places in the p5.Camera class.
  • A bunch of tests which were failing before will pass now.

PR Checklist

@limzykenneth limzykenneth merged commit 6a9ab83 into processing:main Dec 18, 2023
2 checks passed
@limzykenneth
Copy link
Member

Looks good. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants