Fixed the shader in the endShape() example to make the boxes separated from one another
#6656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er by changing *40 to *375 because of the camera changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The update to the camera locked the z at 800 which changed how the boxes are rendered in the example. This pull requests serves to divide them by changing the offset and making it so that the boxes are divided by per-pixel transformations in the shader.
Resolves #6655
Changes:
This changes the offset from *100 to *23 and makes it so that the offset is applied to the position before multiplication of the camera, and projection matrices with the position.
Screenshots of the change:
Before:
After:
PR Checklist
npm run lintpasses