Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed second example in the reference page for acos() #6697

Merged
merged 2 commits into from
Jan 6, 2024

Conversation

sudhanshuv1
Copy link
Contributor

@sudhanshuv1 sudhanshuv1 commented Jan 5, 2024

Resolves #6696

Changes:

Changed the value of a from PI to PI-QUARTER_PI in the second example in reference for acos() (in file src/math/trigonometry.js ). Also changed 3.927 to 2.356 in describe in this example.

Screenshots of the change:

change

PR Checklist

Copy link
Member

@nickmcintyre nickmcintyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @sudhanshuv1! Please make a tiny tweak and we'll merge this.

src/math/trigonometry.js Outdated Show resolved Hide resolved
@nickmcintyre nickmcintyre self-requested a review January 6, 2024 17:37
Copy link
Member

@nickmcintyre nickmcintyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sudhanshuv1!

@nickmcintyre nickmcintyre merged commit 16e47b0 into processing:main Jan 6, 2024
2 checks passed
@sudhanshuv1 sudhanshuv1 deleted the fix-acos-reference branch January 7, 2024 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect example in the reference page for acos()
2 participants