Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix filters run on framebuffers with different sizes from the main canvas #6783

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Fix filters run on framebuffers with different sizes from the main canvas #6783

merged 1 commit into from
Jan 31, 2024

Conversation

davepagurek
Copy link
Contributor

Resolves #6782

Changes:

  • Uses target.width and target.height more consistently to handle cases where target !== this
  • Adds visual tests

Screenshots of the change:

Before:
image

https://editor.p5js.org/davepagurek/sketches/gRuscBCcH

After:
image

https://editor.p5js.org/davepagurek/sketches/gRuscBCcH

PR Checklist

@davepagurek
Copy link
Contributor Author

@perminder-17 does this seem ok to you?

perminder-17
perminder-17 approved these changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@perminder-17 perminder-17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for correcting this and incorporating numerous visual tests.

@davepagurek davepagurek merged commit 8a9d9f6 into processing:main Jan 31, 2024
2 checks passed
aferriss
aferriss approved these changes Feb 1, 2024
View reviewed changes
Copy link
Contributor

@aferriss aferriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@davepagurek davepagurek deleted the fix/filter-on-framebuffer branch February 1, 2024 15:44
@perminder-17 perminder-17 mentioned this pull request Oct 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perminder-17 perminder-17 perminder-17 approved these changes

@aferriss aferriss aferriss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Filter shaders applied to framebuffers with a different size than the main canvas are drawn at the wrong scale
3 participants
@davepagurek @aferriss @perminder-17