Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for fill artifact in WebGL mode when rendering in LINE mode using beginShape #6827

Merged

Conversation

RandomGamingDev
Copy link
Contributor

Resolves #6826

Changes:

Adds a local variable called is_line within p5.RendererGL.prototype.endShape and uses that to check whether or not to apply fill.

Screenshots of the change:

Here's the sketch demonstrating the issue (This is using the unfixed version of p5.js, but if you'd like to use the fixed version just comment out the default import for the p5.min.js import)
https://editor.p5js.org/PotatoBoy/sketches/XOezf6_IR
Without the fix:
image
With the fix:
image

PR Checklist

@Qianqianye Qianqianye merged commit 4296060 into processing:main Mar 9, 2024
2 checks passed
@Qianqianye
Copy link
Contributor

Looks good. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with fill artifact in WebGL mode when rendering in LINE mode using beginShape
2 participants