Update color references #6839
Update color references #6839
Conversation
| @@ -787,8 +1277,10 @@ p5.prototype.noFill = function() { | |||
| }; | |||
|
|
|||
| /** | |||
| * Disables drawing the stroke (outline). If both | |||
| * <a href="#/p5/noStroke">noStroke()</a> and | |||
| * Disables drawing points, lines, and the outlines of shapes. | |||
There was a problem hiding this comment.
How about a simplified version that's similar to the previous version, like 'Disables drawing the outlines of shapes"?
It seems like 'lines' might be a repeat of 'outline', and I'm not sure if we need mention 'points' here.
What do you think? @limzykenneth and @davepagurek
There was a problem hiding this comment.
I think the nice part about having lines and points is that it's maybe not immediately clear that those would be drawn with the stroke color rather than the fill color, since those aren't outlines of shapes. So this is maybe a helpful extra detail to include
There was a problem hiding this comment.
Agreed with @davepagurek that the details would be helpful here.
| * `stroke(255, 165, 0)` or `stroke('orange')` means all shapes drawn after | ||
| * the `stroke()` command will be filled with the color orange. The way these | ||
| * parameters are interpreted may be changed with the | ||
| * Sets the color used to draw points, lines, and the outlines of shapes. |
There was a problem hiding this comment.
Same here. How about 'Sets the color used to draw the outlines of shapes'?
Not sure if we need 'points' and 'lines' here. @limzykenneth @davepagurek
Preparing references in
src/color/setting.jsfor the new website.PR Checklist
npm run lintpasses@Qianqianye @davepagurek @limzykenneth