Update 2D shape references #6840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qianqianye
reviewed
Mar 11, 2024
| * first point. The following pairs of parameters set the coordinates for | ||
| * its next three points. Parameters should proceed clockwise or | ||
| * counter-clockwise around the shape. | ||
| * Draws a quadrilateral (four-sided shape). |
There was a problem hiding this comment.
In the one-line description, can we change it to "four-sided polygon" to keep consistency with the long description? @nickmcintyre
There was a problem hiding this comment.
@Qianqianye I actually removed the word polygon from all the shape descriptions. Happy to restore it, but this seemed simpler, if less precise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparing references in
src/core/shape/2d_primitives.jsfor the new website.PR Checklist
npm run lintpasses@Qianqianye @limzykenneth @davepagurek